From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Subject: Re: [PATCH 0/6] first step toward the new truncate sequence Date: Mon, 31 May 2010 17:13:53 +1000 Message-ID: <20100531071353.GA9453@laptop> References: <20100530204932.GA21002@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: viro@zeniv.linux.org.uk, jack@suse.cz, linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from cantor2.suse.de ([195.135.220.15]:56210 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756305Ab0EaHT4 (ORCPT ); Mon, 31 May 2010 03:19:56 -0400 Content-Disposition: inline In-Reply-To: <20100530204932.GA21002@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, May 30, 2010 at 10:49:32PM +0200, Christoph Hellwig wrote: > This series is something that I see as the first major step towards > a broad switch to the new truncate sequence. The patches get rid > of the _newtrunc variant of blockdev_direct_IO & friends and > *_write_begin, and clean up some bits in that area that make the > switch easier. After this we have all vmtruncate instances except > for inode_setattr in filesystem code. Nice. It looks good. > A second series to deal > with ->setattr will follow and after that we can easily switch > over one filesystem after another. > > I think this is still 2.6.34 material as it will make the fs > switches a lot easier and avoid introducing the _newtrunc variants > for one kernel release. No objections from me, but what is the policy on changing exported APIs without changing the name?