From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Subject: Re: [PATCH 0/6] first step toward the new truncate sequence Date: Mon, 31 May 2010 17:45:04 +1000 Message-ID: <20100531074504.GC9453@laptop> References: <20100530204932.GA21002@lst.de> <20100531071353.GA9453@laptop> <20100531073851.GA4756@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: viro@zeniv.linux.org.uk, jack@suse.cz, linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from cantor.suse.de ([195.135.220.2]:33898 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752638Ab0EaHpI (ORCPT ); Mon, 31 May 2010 03:45:08 -0400 Content-Disposition: inline In-Reply-To: <20100531073851.GA4756@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, May 31, 2010 at 09:38:51AM +0200, Christoph Hellwig wrote: > On Mon, May 31, 2010 at 05:13:53PM +1000, Nick Piggin wrote: > > > A second series to deal > > > with ->setattr will follow and after that we can easily switch > > > over one filesystem after another. > > > > > > I think this is still 2.6.34 material as it will make the fs > > > switches a lot easier and avoid introducing the _newtrunc variants > > > for one kernel release. > > > > No objections from me, but what is the policy on changing exported APIs > > without changing the name? > > There is no policy, but we do it all the time. Yeah, just wondering. There is a pseudo don't-break-exported-symbols thing happening sometimes but while I think it sometimes catches removed symbols in reviews, more subtle breakage probably usually gets past. > Note that we also change > the prototypes for all but cont_write_begin so it's an easy to spot > compile breakage. True.