From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@lst.de>
Subject: exofs_file_fsync
Date: Mon, 31 May 2010 12:09:27 +0200
Message-ID: <20100531100927.GA11149@lst.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org
To: bharrosh@panasas.com
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from verein.lst.de ([213.95.11.210]:59115 "EHLO verein.lst.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752540Ab0EaKJc (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 31 May 2010 06:09:32 -0400
Content-Disposition: inline
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Various odd things going on here:

 - no checks for I_DIRTY and friends, so it will always write out data
 - filemap_write_and_wait is superflous, as it's already done by
   the caller
 - write_inode_now is overkill as it also writes out data, better use
   sync_inode in a similar way to generic_file_fsync