From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: exofs_file_fsync Date: Mon, 31 May 2010 12:27:06 +0200 Message-ID: <20100531102706.GA11961@lst.de> References: <20100531100927.GA11149@lst.de> <4C038E0D.3010400@panasas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org To: Boaz Harrosh Return-path: Received: from verein.lst.de ([213.95.11.210]:41125 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754675Ab0EaK1L (ORCPT ); Mon, 31 May 2010 06:27:11 -0400 Content-Disposition: inline In-Reply-To: <4C038E0D.3010400@panasas.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, May 31, 2010 at 01:23:09PM +0300, Boaz Harrosh wrote: > On 05/31/2010 01:09 PM, Christoph Hellwig wrote: > > Various odd things going on here: > > > > - no checks for I_DIRTY and friends, so it will always write out data > > - filemap_write_and_wait is superflous, as it's already done by > > the caller > > - write_inode_now is overkill as it also writes out data, better use > > sync_inode in a similar way to generic_file_fsync > > I'll look into it, but I think what I did here was to effectively > "data sync" because I wanted a data sync on close and that was the only > vector I already had that's called on close. fsync won't get called at close time. ->release is called on last close and ->flush on every close.