From: tytso@mit.edu
To: Kees Cook <kees.cook@canonical.com>
Cc: linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org,
Randy Dunlap <rdunlap@xenotime.net>,
Andrew Morton <akpm@linux-foundation.org>,
Jiri Kosina <jkosina@suse.cz>,
Dave Young <hidave.darkstar@gmail.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
James Morris <jmorris@namei.org>, Eric Paris <eparis@redhat.com>,
David Howells <dhowells@redhat.com>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Tim Gardner <tim.gardner@canonical.com>,
"Serge E. Hallyn" <serue@us.ibm.com>
Subject: Re: [PATCH v2] fs: block cross-uid sticky symlinks
Date: Mon, 31 May 2010 06:47:08 -0400 [thread overview]
Message-ID: <20100531104708.GR26177@thunk.org> (raw)
In-Reply-To: <20100531030402.GQ6056@outflux.net>
On Sun, May 30, 2010 at 08:04:02PM -0700, Kees Cook wrote:
> - Violates POSIX.
> - POSIX didn't consider this situation and it's not useful to follow
> a broken specification at the cost of security.
POSIX allows implementations to fail requested operations with a
permission denied for reasons beyond that which is specified by the
POSIX implementation. Indeed, POSIX doesn't specify the sticky bit at
all, so implementations that implemented the sticky bit were able to
pass POSIX precisely because it's OK to provide stricter semantics
than that which is specified by POSIX. (The sticky bit is specified
in the XSI exstension to the Single Unix Specification, but the same
principle applies; it's OK for us have additional situations where we
return EACCESS beyond that which was contemplated by POSIX/SUS; this
alone wouldn't cause us to 'violate POSIX'.)
So for people who to argue against this (which I believe to be a
useful restriction, and not one that necessarily has to be done in a
LSM), it's not sufficient to say that it is a POSIX violation, because
it isn't. The sticky bit itself wasn't originally considered by
POSIX, and many systems which implemented the sticky bit had no
problems becoming ceritifed as POSIX compliant.
- Ted
prev parent reply other threads:[~2010-05-31 10:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 3:04 [PATCH v2] fs: block cross-uid sticky symlinks Kees Cook
2010-05-31 3:50 ` Eric W. Biederman
2010-05-31 4:12 ` Kees Cook
2010-05-31 3:54 ` Eric Paris
2010-05-31 4:23 ` Kees Cook
2010-05-31 10:23 ` Alan Cox
2010-05-31 17:50 ` Kees Cook
2010-05-31 18:09 ` Alan Cox
2010-05-31 19:07 ` Kees Cook
2010-05-31 19:52 ` Al Viro
2010-05-31 22:00 ` Kees Cook
2010-05-31 19:27 ` Al Viro
2010-05-31 10:35 ` Christoph Hellwig
2010-05-31 17:57 ` Kees Cook
2010-05-31 23:09 ` James Morris
2010-06-01 3:24 ` Kees Cook
2010-06-01 7:55 ` Christoph Hellwig
2010-06-01 11:55 ` Eric Paris
2010-06-01 14:52 ` Kees Cook
2010-06-01 15:34 ` Eric Paris
2010-06-01 17:31 ` tytso
2010-06-01 15:00 ` Kees Cook
2010-05-31 10:47 ` tytso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100531104708.GR26177@thunk.org \
--to=tytso@mit.edu \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=eparis@redhat.com \
--cc=hidave.darkstar@gmail.com \
--cc=jkosina@suse.cz \
--cc=jmorris@namei.org \
--cc=kees.cook@canonical.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rdunlap@xenotime.net \
--cc=schwidefsky@de.ibm.com \
--cc=serue@us.ibm.com \
--cc=tim.gardner@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).