From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: jack@suse.cz, tytso@mit.edu, linux-ext4@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: nobh mount option in ext3/4?
Date: Mon, 31 May 2010 19:55:58 +0200 [thread overview]
Message-ID: <20100531175557.GC5334@quack.suse.cz> (raw)
In-Reply-To: <20100531124051.GA17262@lst.de>
On Mon 31-05-10 14:40:51, Christoph Hellwig wrote:
> ext3 and ext4 heave inherited the nobh option from ext2, but the
> implementation is rather interesting. Except for the usual
> option parsing / display it's only respected in
> ext3_writeback_writepage/ext4_writepage and the truncate_page
> implementation. Given that we don't take any more than usual
> care to not create buffers heads during read this is not going
> to effect a whole lot.
>
> Is there a good reason to keep these options and the associated
> code complexity? I'd be rather surprised if it gets any sufficient
> testing..
IMHO nobh can go away from ext3/ext4. I would be also in favor of
removing all the nobh logic from VFS and ext2 but for ext2 it saves some
low memory so some people might actually use it.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2010-05-31 17:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 12:40 nobh mount option in ext3/4? Christoph Hellwig
2010-05-31 17:55 ` Jan Kara [this message]
2010-06-01 9:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100531175557.GC5334@quack.suse.cz \
--to=jack@suse.cz \
--cc=hch@lst.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).