* nobh mount option in ext3/4?
@ 2010-05-31 12:40 Christoph Hellwig
2010-05-31 17:55 ` Jan Kara
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2010-05-31 12:40 UTC (permalink / raw)
To: jack, tytso; +Cc: linux-ext4, linux-fsdevel
ext3 and ext4 heave inherited the nobh option from ext2, but the
implementation is rather interesting. Except for the usual
option parsing / display it's only respected in
ext3_writeback_writepage/ext4_writepage and the truncate_page
implementation. Given that we don't take any more than usual
care to not create buffers heads during read this is not going
to effect a whole lot.
Is there a good reason to keep these options and the associated
code complexity? I'd be rather surprised if it gets any sufficient
testing..
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: nobh mount option in ext3/4?
2010-05-31 12:40 nobh mount option in ext3/4? Christoph Hellwig
@ 2010-05-31 17:55 ` Jan Kara
2010-06-01 9:10 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kara @ 2010-05-31 17:55 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: jack, tytso, linux-ext4, linux-fsdevel
On Mon 31-05-10 14:40:51, Christoph Hellwig wrote:
> ext3 and ext4 heave inherited the nobh option from ext2, but the
> implementation is rather interesting. Except for the usual
> option parsing / display it's only respected in
> ext3_writeback_writepage/ext4_writepage and the truncate_page
> implementation. Given that we don't take any more than usual
> care to not create buffers heads during read this is not going
> to effect a whole lot.
>
> Is there a good reason to keep these options and the associated
> code complexity? I'd be rather surprised if it gets any sufficient
> testing..
IMHO nobh can go away from ext3/ext4. I would be also in favor of
removing all the nobh logic from VFS and ext2 but for ext2 it saves some
low memory so some people might actually use it.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: nobh mount option in ext3/4?
2010-05-31 17:55 ` Jan Kara
@ 2010-06-01 9:10 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2010-06-01 9:10 UTC (permalink / raw)
To: Jan Kara; +Cc: Christoph Hellwig, tytso, linux-ext4, linux-fsdevel
On Mon, May 31, 2010 at 07:55:58PM +0200, Jan Kara wrote:
> IMHO nobh can go away from ext3/ext4.
I'll send patches.
> I would be also in favor of
> removing all the nobh logic from VFS and ext2 but for ext2 it saves some
> low memory so some people might actually use it.
I agree that we should get rid of it entirely, but that's the next step.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-01 9:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-31 12:40 nobh mount option in ext3/4? Christoph Hellwig
2010-05-31 17:55 ` Jan Kara
2010-06-01 9:10 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).