From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@lst.de>
Subject: Re: exofs_file_fsync
Date: Tue, 1 Jun 2010 12:05:07 +0200
Message-ID: <20100601100507.GC28762@lst.de>
References: <20100531100927.GA11149@lst.de> <4C038E0D.3010400@panasas.com> <20100531102706.GA11961@lst.de> <4C038FE5.8000504@panasas.com> <20100531103349.GA12196@lst.de> <4C03BD14.5030004@panasas.com> <4C03BDB9.30904@panasas.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Christoph Hellwig <hch@lst.de>, linux-fsdevel@vger.kernel.org
To: Boaz Harrosh <bharrosh@panasas.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from verein.lst.de ([213.95.11.210]:53220 "EHLO verein.lst.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753069Ab0FAKFM (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 1 Jun 2010 06:05:12 -0400
Content-Disposition: inline
In-Reply-To: <4C03BDB9.30904@panasas.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Mon, May 31, 2010 at 04:46:33PM +0300, Boaz Harrosh wrote:
> You think I also need a:
> 	if (!(inode->i_state & I_DIRTY))
> 		return ret;
> 	if (datasync && !(inode->i_state & I_DIRTY_DATASYNC))
> 		return ret;
> before the  write_inode_now call ?

You don't strictly need it, but without it you will perform a lot
of work for no gain if the inode is not actually dirty.