From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH ver3] exofs: New truncate sequence
Date: Tue, 1 Jun 2010 13:36:20 +0200
Message-ID: <20100601113620.GA4647@lst.de>
References: <4C03ABCA.4050602@panasas.com> <4C04EF92.6060600@panasas.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Christoph Hellwig <hch@lst.de>, Nick Piggin <npiggin@suse.de>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	open-osd <osd-dev@open-osd.org>
To: Boaz Harrosh <bharrosh@panasas.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from verein.lst.de ([213.95.11.210]:48516 "EHLO verein.lst.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752915Ab0FALgs (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 1 Jun 2010 07:36:48 -0400
Content-Disposition: inline
In-Reply-To: <4C04EF92.6060600@panasas.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Jun 01, 2010 at 02:31:30PM +0300, Boaz Harrosh wrote:
> +static int _do_truncate(struct inode *inode, loff_t newsize)
>  {
>  	struct exofs_i_info *oi = exofs_i(inode);
>  	int ret;
>  
>  	inode->i_mtime = inode->i_ctime = CURRENT_TIME;
>  
> +	ret = exofs_oi_truncate(oi, (u64)newsize);
> +	EXOFS_DBGMSG("(0x%lx) size=0x%llx\n", inode->i_ino, newsize);
>  	return ret;

Maybe I'm beeing picky, but I really don't see the need for this
function either, especially given that is has a single caller.