From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Subject: time_attrs argument for security_path_truncate Date: Wed, 2 Jun 2010 01:50:55 +1000 Message-ID: <20100601155055.GZ9453@laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: security@kernel.org, linux-fsdevel@vger.kernel.org, tomoyo-users-en@lists.sourceforge.jp, Kentaro Takeda Return-path: Received: from cantor2.suse.de ([195.135.220.15]:55243 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932118Ab0FAPvG (ORCPT ); Tue, 1 Jun 2010 11:51:06 -0400 Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: It appears like the time_attrs parameter of security_path_truncate is unused by any security module, so I wonder if we can remove it? We cannot really get it right for truncate(2) calls anyway without holding i_mutex over the call (because ATTR_MTIME|ATTR_CTIME is effectively set iff size changes). So the meaning of this parameter today is misleading anyway. Thanks, Nick