From: Christoph Hellwig <hch@lst.de>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-fsdevel@vger.kernel.org, open-osd <osd-dev@open-osd.org>
Subject: Re: [PATCH ver2] exofs: exofs_file_fsync and exofs_file_flush correctness
Date: Tue, 1 Jun 2010 18:17:43 +0200 [thread overview]
Message-ID: <20100601161743.GA17609@lst.de> (raw)
In-Reply-To: <4C05311A.8000801@panasas.com>
On Tue, Jun 01, 2010 at 07:11:06PM +0300, Boaz Harrosh wrote:
> +/* exofs_file_fsync - flush the inode to disk
> + *
> + * @datasync is not used. All metadata is written in one place regardless.
> + * the writeout is synchronous
> + */
It actually is used now :)
> static int exofs_flush(struct file *file, fl_owner_t id)
> {
> - exofs_file_fsync(file, 1);
> + int ret = vfs_fsync_range(file, 0, LLONG_MAX, 0);
> /* TODO: Flush the OSD target */
> - return 0;
> + return ret;
why not just:
return vfs_fsync(file, 0);
next prev parent reply other threads:[~2010-06-01 16:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 10:09 exofs_file_fsync Christoph Hellwig
2010-05-31 10:23 ` exofs_file_fsync Boaz Harrosh
2010-05-31 10:27 ` exofs_file_fsync Christoph Hellwig
2010-05-31 10:31 ` exofs_file_fsync Boaz Harrosh
2010-05-31 10:33 ` exofs_file_fsync Christoph Hellwig
2010-05-31 13:43 ` exofs_file_fsync Boaz Harrosh
2010-05-31 13:46 ` exofs_file_fsync Boaz Harrosh
2010-06-01 10:05 ` exofs_file_fsync Christoph Hellwig
2010-06-01 10:04 ` exofs_file_fsync Christoph Hellwig
2010-06-01 15:29 ` exofs_file_fsync Boaz Harrosh
2010-06-01 15:30 ` [PATCH] exofs: exofs_file_fsync correctness Boaz Harrosh
2010-06-01 15:33 ` [osd-dev] " Boaz Harrosh
2010-06-01 15:34 ` Christoph Hellwig
2010-06-01 15:40 ` Boaz Harrosh
2010-06-01 15:47 ` Christoph Hellwig
2010-06-01 16:10 ` Boaz Harrosh
2010-06-01 16:11 ` [PATCH ver2] exofs: exofs_file_fsync and exofs_file_flush correctness Boaz Harrosh
2010-06-01 16:17 ` Christoph Hellwig [this message]
2010-06-01 16:36 ` Boaz Harrosh
2010-06-01 17:03 ` [PATCH ver3] " Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100601161743.GA17609@lst.de \
--to=hch@lst.de \
--cc=bharrosh@panasas.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=osd-dev@open-osd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).