From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH ver2] exofs: exofs_file_fsync and exofs_file_flush correctness
Date: Tue, 1 Jun 2010 18:17:43 +0200
Message-ID: <20100601161743.GA17609@lst.de>
References: <20100531100927.GA11149@lst.de> <4C0527AF.6090502@panasas.com> <4C05311A.8000801@panasas.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Christoph Hellwig <hch@lst.de>, linux-fsdevel@vger.kernel.org,
	open-osd <osd-dev@open-osd.org>
To: Boaz Harrosh <bharrosh@panasas.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from verein.lst.de ([213.95.11.210]:55268 "EHLO verein.lst.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755645Ab0FAQSO (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 1 Jun 2010 12:18:14 -0400
Content-Disposition: inline
In-Reply-To: <4C05311A.8000801@panasas.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Jun 01, 2010 at 07:11:06PM +0300, Boaz Harrosh wrote:
> +/* exofs_file_fsync - flush the inode to disk
> + *
> + *   @datasync is not used. All metadata is written in one place regardless.
> + *   the writeout is synchronous
> + */

It actually is used now :)

>  static int exofs_flush(struct file *file, fl_owner_t id)
>  {
> -	exofs_file_fsync(file, 1);
> +	int ret = vfs_fsync_range(file, 0, LLONG_MAX, 0);
>  	/* TODO: Flush the OSD target */
> -	return 0;
> +	return ret;

why not just:

	return vfs_fsync(file, 0);