From: Nick Piggin <npiggin@suse.de>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: linux-security-module@vger.kernel.org,
torvalds@linux-foundation.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] LSM: Remove unused time_attrs argument.
Date: Wed, 2 Jun 2010 13:59:21 +1000 [thread overview]
Message-ID: <20100602035921.GI9453@laptop> (raw)
In-Reply-To: <20100602035012.GH9453@laptop>
On Wed, Jun 02, 2010 at 01:50:12PM +1000, Nick Piggin wrote:
> On Wed, Jun 02, 2010 at 12:28:24PM +0900, Tetsuo Handa wrote:
> > When commit be6d3e56a6b9b3a4ee44a0685e39e595073c6f0d "introduce new LSM hooks
> > where vfsmount is available." was proposed, regarding security_path_truncate(),
> > only "struct file *" argument (which AppArmor wanted to use) was removed.
> > But length and time_attrs arguments are not used by TOMOYO nor AppArmor.
>
> Well if length is not used either, can we remove that too seeing as
> we're changing the API anyway.
>
> Length would also be an iffy thing to use here because we're not
> holding the i_mutex, so it may change between being checked and
> truncate checking it.
To clarify, not the length of course, but the i_size. That could
be a problem if a security module thought it could allow only expanding
truncates by checking i_size, for example.
next prev parent reply other threads:[~2010-06-02 3:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 15:50 time_attrs argument for security_path_truncate Nick Piggin
2010-06-01 17:04 ` [Security] " Linus Torvalds
2010-06-01 17:24 ` Nick Piggin
2010-06-01 17:52 ` Linus Torvalds
2010-06-02 3:28 ` [PATCH] LSM: Remove unused time_attrs argument Tetsuo Handa
2010-06-02 3:50 ` Nick Piggin
2010-06-02 3:59 ` Nick Piggin [this message]
2010-06-02 4:24 ` Tetsuo Handa
2010-06-02 4:41 ` Nick Piggin
2010-06-02 5:22 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100602035921.GI9453@laptop \
--to=npiggin@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).