From: Dan Carpenter <error27@gmail.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Jens Axboe <jens.axboe@oracle.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [patch] fcntl: return -EFAULT if copy_to_user fails
Date: Thu, 3 Jun 2010 12:04:02 +0200 [thread overview]
Message-ID: <20100603100402.GR5483@bicker> (raw)
copy_to_user() returns the number of bytes remaining, but we want to
return -EFAULT.
ret = fcntl(fd, F_SETOWN_EX, NULL);
With the original code ret would be 8 here.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/fs/fcntl.c b/fs/fcntl.c
index f74d270..0ea7b0f 100644
--- a/fs/fcntl.c
+++ b/fs/fcntl.c
@@ -274,7 +274,7 @@ static int f_setown_ex(struct file *filp, unsigned long arg)
ret = copy_from_user(&owner, owner_p, sizeof(owner));
if (ret)
- return ret;
+ return -EFAULT;
switch (owner.type) {
case F_OWNER_TID:
next reply other threads:[~2010-06-03 10:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 10:04 Dan Carpenter [this message]
2010-06-03 10:22 ` [patch] fcntl: return -EFAULT if copy_to_user fails Takuya Yoshikawa
[not found] ` <4C07826A.6060302@oss.ntt.co.jp>
2010-06-03 10:35 ` [patch v2] " Dan Carpenter
2010-06-03 10:42 ` Peter Zijlstra
2010-06-03 11:59 ` Jens Axboe
[not found] ` <4C07990A.8080508@fusionio.com>
2010-06-03 12:16 ` Takuya Yoshikawa
2010-06-03 12:38 ` Eric Dumazet
2010-06-03 13:10 ` Nick Piggin
2010-06-03 13:24 ` Takuya Yoshikawa
2010-06-03 13:42 ` Eric Dumazet
2010-06-03 12:45 ` Dan Carpenter
2010-06-04 11:14 ` Dan Carpenter
2010-06-03 12:45 ` [patch] " Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100603100402.GR5483@bicker \
--to=error27@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=jens.axboe@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=oleg@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).