From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [patch v2] fix truncate inode time modification breakage Date: Thu, 3 Jun 2010 13:09:14 +0200 Message-ID: <20100603110914.GA14006@lst.de> References: <20100601133923.GT9453@laptop> <20100601134801.GA11061@lst.de> <20100601135655.GU9453@laptop> <20100602195538.GG6152@laptop> <20100603091434.GA6822@laptop> <20100603100724.GE6822@laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Nick Piggin , hch@lst.de, viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org To: Miklos Szeredi Return-path: Received: from verein.lst.de ([213.95.11.210]:53193 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751463Ab0FCLJY (ORCPT ); Thu, 3 Jun 2010 07:09:24 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Jun 03, 2010 at 12:58:22PM +0200, Miklos Szeredi wrote: > (In fact I think it would be cleanest if truncate/ftruncate was a > separate operation from setattr on all levels, but that's a different > story.) It might be. Let's finish off the current transition after which we should have all truncate code in a clean if (valid & ATTR_SIZE) inside the setattr method. We can think about re-introducing a proper truncate method after that, although I'm not sure how much duplication the timestamp and mode updates will mean. The upside of it is that many filesystems could remove the setattr method after this, though.