From: Christoph Hellwig <hch@infradead.org>
To: Nick Piggin <npiggin@suse.de>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Frank Mayhar <fmayhar@google.com>,
John Stultz <johnstul@us.ibm.com>,
Andi Kleen <ak@linux.intel.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [patch 1/4] fs: cleanup files_lock
Date: Fri, 4 Jun 2010 04:38:18 -0400 [thread overview]
Message-ID: <20100604083818.GA9987@infradead.org> (raw)
In-Reply-To: <20100604072618.227745945@suse.de>
On Fri, Jun 04, 2010 at 04:43:08PM +1000, Nick Piggin wrote:
> Lock tty_files with a new spinlock, tty_files_lock; provide helpers to
> manipulate the per-sb files list; unexport the files_lock spinlock.
I'm still not entirely happy with this. You keep making the tty a
special case by removing it from the files per-sb files list while
nothing else in the system is removed from it.
Thinks would be much better if you could untangle the tty code from
abuse of file->f_u.fu_list entirely. And from a naive look at the
tty code that actually seems pretty easy. file->private for ttys
currently directly points to the tty struct. If you add a tty_private
there which points back to the file, the tty and contains a list_head
the open files in tty code tracking code can be completely divorced
from the per-sb file tracking. After that we can decide what to do
with the per-sb file tracking, where my favourite still is to get
rid of it entirely.
next prev parent reply other threads:[~2010-06-04 8:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 6:43 [patch 0/4] Initial vfs scalability patches again Nick Piggin
2010-06-04 6:43 ` [patch 1/4] fs: cleanup files_lock Nick Piggin
2010-06-04 8:38 ` Christoph Hellwig [this message]
2010-06-04 14:20 ` Nick Piggin
2010-06-04 14:39 ` Andi Kleen
2010-06-04 15:10 ` Christoph Hellwig
2010-06-04 18:39 ` [PATCH, RFC] tty: stop abusing file->f_u.fu_list Christoph Hellwig
2010-06-04 19:35 ` Al Viro
2010-06-05 11:39 ` Nick Piggin
2010-06-08 5:22 ` Nick Piggin
2010-06-04 6:43 ` [patch 2/4] lglock: introduce special lglock and brlock spin locks Nick Piggin
2010-06-04 7:56 ` Eric Dumazet
2010-06-04 14:13 ` Nick Piggin
2010-06-04 14:24 ` Eric Dumazet
2010-06-04 15:03 ` Paul E. McKenney
2010-06-04 15:12 ` Nick Piggin
2010-06-04 6:43 ` [patch 3/4] fs: scale files_lock Nick Piggin
2010-06-04 6:43 ` [patch 4/4] fs: brlock vfsmount_lock Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100604083818.GA9987@infradead.org \
--to=hch@infradead.org \
--cc=ak@linux.intel.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=ebiederm@xmission.com \
--cc=fmayhar@google.com \
--cc=gregkh@suse.de \
--cc=johnstul@us.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).