From: Al Viro <viro@ZenIV.linux.org.uk>
To: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 43/58] switch ocfs2 to ->evict_inode()
Date: Wed, 9 Jun 2010 02:49:19 +0100 [thread overview]
Message-ID: <20100609014919.GV31073@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20100609011959.GR31073@ZenIV.linux.org.uk>
On Wed, Jun 09, 2010 at 02:19:59AM +0100, Al Viro wrote:
> On Tue, Jun 08, 2010 at 05:17:11PM -0700, Joel Becker wrote:
> > I do think it works, though, if you check for MAYBE_ORPHANED.
> >
> > if (inode->i_nlink && !(oi->ip_falgs & OCFS2_INODE_MAYBE_ORPHANED)) {
> > ocfs2_cleanup_delete_inode(inode, 0);
> > goto bail;
> > }
>
> Damn, that probably means we have other problems like that. Other filesystems
> that have extra "delete" cases (and do not play with i_nlink like gfs2 does)
> and have non-trivial ->delete_inode().
>
> Ho-hum... OK, not too many. btrfs seems to be the only one besides ocfs2.
> Will fix...
>
> I'll post replacement patches in a few.
Posted and pushed to vfs-2.6.git...
next prev parent reply other threads:[~2010-06-09 1:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 22:22 [PATCH 43/58] switch ocfs2 to ->evict_inode() Al Viro
2010-06-09 0:17 ` Joel Becker
2010-06-09 1:19 ` Al Viro
2010-06-09 1:49 ` Al Viro [this message]
2010-06-09 1:44 ` [PATCH 43/58][v2] " Al Viro
2010-06-09 1:53 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100609014919.GV31073@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).