From: Christoph Hellwig <hch@lst.de>
To: Nick Piggin <npiggin@suse.de>, Tao Ma <tao.ma@oracle.com>,
ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] ocfs2: Remove the deprecated inode_setattr.
Date: Wed, 9 Jun 2010 12:14:34 +0200 [thread overview]
Message-ID: <20100609101434.GA17108@lst.de> (raw)
In-Reply-To: <20100609101207.GB21239@mail.oracle.com>
On Wed, Jun 09, 2010 at 03:12:07AM -0700, Joel Becker wrote:
> On Wed, Jun 09, 2010 at 07:38:04PM +1000, Nick Piggin wrote:
> > On Wed, Jun 09, 2010 at 05:29:37PM +0800, Tao Ma wrote:
> > > We have a inode_newsize_ok check at the top of ocfs2_setattr when we
> > > do the real work of truncate(it is far above, so the patch can't
> > > have it. ;) ). So we don't need to worry about that actually.
> >
> > OK, can you comment that or just open-code the truncate part of
> > simple_setsize? It should be helpful for example with Christoph's
> > truncate cleanup work.
>
> Just open-code it. The void calls are much nicer than useless
> return code boilerplate.
Note that if you rebase against vfs.git #for_next simple_setsize is
replaced with a truncate_setsize that does all the work but the
inode_newsize_ok check. As I mentioned before please do the work ontop
of that branch, it does make the ->setattr ATTR_SIZE implementation much
nicer for the filesystems.
next prev parent reply other threads:[~2010-06-09 10:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1276073300-7360-1-git-send-email-tao.ma@oracle.com>
2010-06-09 9:16 ` [PATCH] ocfs2: Remove the deprecated inode_setattr Nick Piggin
2010-06-09 9:29 ` Tao Ma
2010-06-09 9:38 ` Nick Piggin
2010-06-09 10:12 ` Joel Becker
2010-06-09 10:14 ` Christoph Hellwig [this message]
2010-06-09 19:53 ` [Ocfs2-devel] " Joel Becker
2010-06-09 10:01 ` Christoph Hellwig
2010-06-09 13:43 ` Tao Ma
[not found] ` <20100609100839.GA21239@mail.oracle.com>
2010-06-09 10:43 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100609101434.GA17108@lst.de \
--to=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=ocfs2-devel@oss.oracle.com \
--cc=tao.ma@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).