From: Christoph Hellwig <hch@infradead.org>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/58] unify fs/inode.c callers of clear_inode()
Date: Wed, 9 Jun 2010 09:00:47 -0400 [thread overview]
Message-ID: <20100609130047.GA3861@infradead.org> (raw)
In-Reply-To: <E1OM74i-0004XF-VD@ZenIV.linux.org.uk>
> +static void evict(struct inode *inode, int delete)
How about calling this evict_inode? That gives a better grepable
identifier in backtraces and also fits the tradition of other
wrappers for methods.
> +{
> + const struct super_operations *op = inode->i_sb->s_op;
> +
> + if (delete && op->delete_inode) {
> + op->delete_inode(inode);
What's the point in having the local op variable?
next prev parent reply other threads:[~2010-06-09 13:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 22:15 [PATCH 2/58] unify fs/inode.c callers of clear_inode() Al Viro
2010-06-09 13:00 ` Christoph Hellwig [this message]
2010-06-09 13:15 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100609130047.GA3861@infradead.org \
--to=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).