From: Christoph Hellwig <hch@infradead.org>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 7/58] new helper: end_writeback()
Date: Wed, 9 Jun 2010 09:02:16 -0400 [thread overview]
Message-ID: <20100609130216.GB3861@infradead.org> (raw)
In-Reply-To: <E1OM75W-0004Y4-W4@ZenIV.linux.org.uk>
On Tue, Jun 08, 2010 at 11:16:02PM +0100, Al Viro wrote:
>
> Essentially, the minimal variant of ->evict_inode(). It's
> a trimmed-down clear_inode(), sans any fs callbacks. Once
> it returns we know that no async writeback will be happening;
> every ->evict_inode() instance should do that once and do that
> before doing anything ->write_inode() could interfere with
> (e.g. freeing the on-disk inode).
Naming seems a bit unfortunate - this really sounds like something
in page writeback. In fact I'd almost bet we had a function with
that name there in the past.
Care to slap an inode_ prefix on it?
next prev parent reply other threads:[~2010-06-09 13:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 22:16 [PATCH 7/58] new helper: end_writeback() Al Viro
2010-06-09 13:02 ` Christoph Hellwig [this message]
2010-06-09 13:20 ` Al Viro
2010-06-09 13:50 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100609130216.GB3861@infradead.org \
--to=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).