From: Nikanth Karthikesan <knikanth@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, Nick Piggin <npiggin@suse.de>,
Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] Documentation: New truncate sequence: Remove reference to nonexistent ->setsize
Date: Wed, 9 Jun 2010 15:40:04 +0530 [thread overview]
Message-ID: <201006091540.04129.knikanth@suse.de> (raw)
In-Reply-To: <20100609100016.GA15403@lst.de>
On Wednesday 09 June 2010 15:30:16 Christoph Hellwig wrote:
> On Wed, Jun 09, 2010 at 03:29:14PM +0530, Nikanth Karthikesan wrote:
> > - truncate: Deprecated. This will not be called if ->setsize is defined.
> > - Called by the VFS to change the size of a file. The
> > + truncate: Deprecated. Called by the VFS to change the size of a file.
> > The i_size field of the inode is set to the desired size by the
>
> I'd just remove the whole description - the deprecated should be enough.
>
There is a note below the description, which should prevent new users.
Note: ->truncate and vmtruncate are deprecated. Do not add new
instances/calls of these. Filesystems should be converted to do their
truncate sequence via ->setattr().
But leaving it as it is would help, people understand how the deprecated
callback works. IMHO it could be left till all the users are converted.
Thanks
Nikanth
prev parent reply other threads:[~2010-06-09 10:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-09 9:59 [PATCH] Documentation: New truncate sequence: Remove reference to nonexistent ->setsize Nikanth Karthikesan
2010-06-09 10:00 ` Christoph Hellwig
2010-06-09 10:10 ` Nikanth Karthikesan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006091540.04129.knikanth@suse.de \
--to=knikanth@suse.de \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).