* [PATCH] Documentation: New truncate sequence: Remove reference to nonexistent ->setsize
@ 2010-06-09 9:59 Nikanth Karthikesan
2010-06-09 10:00 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Nikanth Karthikesan @ 2010-06-09 9:59 UTC (permalink / raw)
To: Alexander Viro; +Cc: linux-fsdevel, Nick Piggin, Christoph Hellwig, Jan Kara
The documentation refers to ->setsize which does not exist. Remove it.
Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
---
diff --git a/Documentation/filesystems/vfs.txt b/Documentation/filesystems/vfs.txt
index 94677e7..e8b1b27 100644
--- a/Documentation/filesystems/vfs.txt
+++ b/Documentation/filesystems/vfs.txt
@@ -401,8 +401,7 @@ otherwise noted.
started might not be in the page cache at the end of the
walk).
- truncate: Deprecated. This will not be called if ->setsize is defined.
- Called by the VFS to change the size of a file. The
+ truncate: Deprecated. Called by the VFS to change the size of a file. The
i_size field of the inode is set to the desired size by the
VFS before this method is called. This method is called by
the truncate(2) system call and related functionality.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation: New truncate sequence: Remove reference to nonexistent ->setsize
2010-06-09 9:59 [PATCH] Documentation: New truncate sequence: Remove reference to nonexistent ->setsize Nikanth Karthikesan
@ 2010-06-09 10:00 ` Christoph Hellwig
2010-06-09 10:10 ` Nikanth Karthikesan
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2010-06-09 10:00 UTC (permalink / raw)
To: Nikanth Karthikesan
Cc: Alexander Viro, linux-fsdevel, Nick Piggin, Christoph Hellwig,
Jan Kara
On Wed, Jun 09, 2010 at 03:29:14PM +0530, Nikanth Karthikesan wrote:
> - truncate: Deprecated. This will not be called if ->setsize is defined.
> - Called by the VFS to change the size of a file. The
> + truncate: Deprecated. Called by the VFS to change the size of a file. The
> i_size field of the inode is set to the desired size by the
I'd just remove the whole description - the deprecated should be enough.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation: New truncate sequence: Remove reference to nonexistent ->setsize
2010-06-09 10:00 ` Christoph Hellwig
@ 2010-06-09 10:10 ` Nikanth Karthikesan
0 siblings, 0 replies; 3+ messages in thread
From: Nikanth Karthikesan @ 2010-06-09 10:10 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Alexander Viro, linux-fsdevel, Nick Piggin, Jan Kara
On Wednesday 09 June 2010 15:30:16 Christoph Hellwig wrote:
> On Wed, Jun 09, 2010 at 03:29:14PM +0530, Nikanth Karthikesan wrote:
> > - truncate: Deprecated. This will not be called if ->setsize is defined.
> > - Called by the VFS to change the size of a file. The
> > + truncate: Deprecated. Called by the VFS to change the size of a file.
> > The i_size field of the inode is set to the desired size by the
>
> I'd just remove the whole description - the deprecated should be enough.
>
There is a note below the description, which should prevent new users.
Note: ->truncate and vmtruncate are deprecated. Do not add new
instances/calls of these. Filesystems should be converted to do their
truncate sequence via ->setattr().
But leaving it as it is would help, people understand how the deprecated
callback works. IMHO it could be left till all the users are converted.
Thanks
Nikanth
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-09 10:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-09 9:59 [PATCH] Documentation: New truncate sequence: Remove reference to nonexistent ->setsize Nikanth Karthikesan
2010-06-09 10:00 ` Christoph Hellwig
2010-06-09 10:10 ` Nikanth Karthikesan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).