From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikanth Karthikesan Subject: Re: [PATCH] Documentation: New truncate sequence: Remove reference to nonexistent ->setsize Date: Wed, 9 Jun 2010 15:40:04 +0530 Message-ID: <201006091540.04129.knikanth@suse.de> References: <201006091529.14933.knikanth@suse.de> <20100609100016.GA15403@lst.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Alexander Viro , linux-fsdevel@vger.kernel.org, Nick Piggin , Jan Kara To: Christoph Hellwig Return-path: Received: from cantor2.suse.de ([195.135.220.15]:57463 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751677Ab0FIKIG (ORCPT ); Wed, 9 Jun 2010 06:08:06 -0400 In-Reply-To: <20100609100016.GA15403@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wednesday 09 June 2010 15:30:16 Christoph Hellwig wrote: > On Wed, Jun 09, 2010 at 03:29:14PM +0530, Nikanth Karthikesan wrote: > > - truncate: Deprecated. This will not be called if ->setsize is defined. > > - Called by the VFS to change the size of a file. The > > + truncate: Deprecated. Called by the VFS to change the size of a file. > > The i_size field of the inode is set to the desired size by the > > I'd just remove the whole description - the deprecated should be enough. > There is a note below the description, which should prevent new users. Note: ->truncate and vmtruncate are deprecated. Do not add new instances/calls of these. Filesystems should be converted to do their truncate sequence via ->setattr(). But leaving it as it is would help, people understand how the deprecated callback works. IMHO it could be left till all the users are converted. Thanks Nikanth