From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 2/2] check ATTR_SIZE contraints in inode_change_ok
Date: Thu, 10 Jun 2010 10:21:41 +0200
Message-ID: <20100610082140.GA2039@lst.de>
References: <20100601113915.GA4861@lst.de> <20100601113937.GB4929@lst.de> <20100609073336.GV26335@laptop> <20100609094121.GC3393@quack.suse.cz> <20100609100715.GA15837@lst.de> <20100609102623.GB26335@laptop>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Christoph Hellwig <hch@lst.de>, Jan Kara <jack@suse.cz>,
	viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
	mfasheh@suse.de
To: Nick Piggin <npiggin@suse.de>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from verein.lst.de ([213.95.11.210]:48841 "EHLO verein.lst.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752064Ab0FJIVr (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 10 Jun 2010 04:21:47 -0400
Content-Disposition: inline
In-Reply-To: <20100609102623.GB26335@laptop>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Wed, Jun 09, 2010 at 08:26:23PM +1000, Nick Piggin wrote:
> What about network filesystems? Some (ceph, cifs) seem to do i_size
> checks under i_lock.

Hmm, If we don't get that sorted we need to split out the current
inode_change_ok into __inode_change_ok.  Then again these filesystems
will also need locking for the other attributes.  I'll do another
audit for these.