From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joel Becker Subject: Re: [PATCH v3] ocfs2: Let ocfs2_setattr use new truncate sequence. Date: Thu, 10 Jun 2010 01:47:07 -0700 Message-ID: <20100610084707.GG30672@mail.oracle.com> References: <20100610044234.GD26335@laptop> <1276146485-9346-1-git-send-email-tao.ma@oracle.com> <20100610082711.GA2173@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Tao Ma , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Nick Piggin To: Christoph Hellwig Return-path: Content-Disposition: inline In-Reply-To: <20100610082711.GA2173@lst.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Jun 10, 2010 at 10:27:11AM +0200, Christoph Hellwig wrote: > You just leave the duplicate inode_newsize_ok in, but still have > one as part of inode_change_ok. See the previous thread - we'll > need to move inode_change_ok to under the cluster locks, both > for the truncate and non-truncate case. Is your concern that the u/gid checks may be against stale ids? > > + truncate_setsize(inode, attr->ia_size); > > But any reason this isn't done inside the > > if (size_change && attr->ia_size != inode->i_size) { > > conditional above? You'll never get size and uid/gid changes in the > same request, so there won't be any change in behaviour. I think the code exists as-is so that the i_size update only happens after the quota transfer has been approved. Jan added the quota bits in this location. I can't see a standard posix op that changes size and ids at the same time. I think we just add BUG_ON expressions that ensure such a behavior, right? Joel -- "I'm living so far beyond my income that we may almost be said to be living apart." - e e cummings Joel Becker Principal Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127