From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/2]: writeback: remove writeback_inodes_wbc Date: Thu, 10 Jun 2010 15:07:40 +0200 Message-ID: <20100610130740.GA16949@lst.de> References: <20100610100727.GA7434@lst.de> <4C10E1B1.50003@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org To: Jens Axboe Return-path: Received: from verein.lst.de ([213.95.11.210]:60538 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750937Ab0FJNHn (ORCPT ); Thu, 10 Jun 2010 09:07:43 -0400 Content-Disposition: inline In-Reply-To: <4C10E1B1.50003@kernel.dk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Jun 10, 2010 at 02:59:29PM +0200, Jens Axboe wrote: > On 2010-06-10 12:07, Christoph Hellwig wrote: > > This was just an odd wrapper around writeback_inodes_wb. Removing this > > also allows to get rid of the bdi member of struct writeback_control > > which was rather out of place there. > > Both this and the next look fine to me, but probably more appropriate > for 2.6.36. Yes, absolutely.