From: Christoph Hellwig <hch@lst.de>
To: Tao Ma <tao.ma@oracle.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Joel Becker <joel.becker@oracle.com>,
Christoph Hellwig <hch@lst.de>, Nick Piggin <npiggin@suse.de>
Subject: Re: [PATCH v4] ocfs2: Let ocfs2_setattr use new truncate sequence.
Date: Fri, 11 Jun 2010 08:56:35 +0200 [thread overview]
Message-ID: <20100611065635.GA19692@lst.de> (raw)
In-Reply-To: <1276226869-11123-1-git-send-email-tao.ma@oracle.com>
This looks correct, but still has the second if ATTR_SIZE block that
I commented on last time. I'd really prefer if the filesystems could
move the truncate handling into a single conditional to simplify
auditing for it and possibly splitting it out into a separate method
later.
And btw, the S_ISREG check which you only have on the first ATTR_SIZE
check is superflous, the VFS only does ATTR_SIZE calls on regular files.
next prev parent reply other threads:[~2010-06-11 6:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 3:27 [PATCH v4] ocfs2: Let ocfs2_setattr use new truncate sequence Tao Ma
2010-06-11 4:50 ` Nick Piggin
2010-06-11 6:56 ` Christoph Hellwig [this message]
2010-06-11 7:16 ` Tao Ma
2010-06-11 7:19 ` Christoph Hellwig
2010-06-11 7:50 ` Joel Becker
2010-06-11 7:55 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100611065635.GA19692@lst.de \
--to=hch@lst.de \
--cc=joel.becker@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=tao.ma@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).