From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v4] ocfs2: Let ocfs2_setattr use new truncate sequence. Date: Fri, 11 Jun 2010 09:19:45 +0200 Message-ID: <20100611071945.GA20496@lst.de> References: <1276226869-11123-1-git-send-email-tao.ma@oracle.com> <20100611065635.GA19692@lst.de> <4C11E2BD.2020207@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Joel Becker , Nick Piggin To: Tao Ma Return-path: Content-Disposition: inline In-Reply-To: <4C11E2BD.2020207@oracle.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Jun 11, 2010 at 03:16:13PM +0800, Tao Ma wrote: > Hi Christoph, > > On 06/11/2010 02:56 PM, Christoph Hellwig wrote: > >This looks correct, but still has the second if ATTR_SIZE block that > >I commented on last time. I'd really prefer if the filesystems could > >move the truncate handling into a single conditional to simplify > >auditing for it and possibly splitting it out into a separate method > >later. > oh, that would be much work for ocfs2 to do from my perspective. So I > would really want to leave it as-is and I have add it to my to-do list. Oh right, you start a new transaction there. Sorry, ignore my request and keep it as it is for now. I don't think doing truncatate in separate transactions actually is correct, though but that's no change with this patch.