From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joel Becker Subject: Re: [PATCH v4] ocfs2: Let ocfs2_setattr use new truncate sequence. Date: Fri, 11 Jun 2010 00:55:28 -0700 Message-ID: <20100611075528.GD23946@mail.oracle.com> References: <1276226869-11123-1-git-send-email-tao.ma@oracle.com> <20100611065635.GA19692@lst.de> <4C11E2BD.2020207@oracle.com> <20100611071945.GA20496@lst.de> <20100611075020.GC23946@mail.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE To: Christoph Hellwig , Tao Ma , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Nick Piggin Return-path: Content-Disposition: inline In-Reply-To: <20100611075020.GC23946@mail.oracle.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Jun 11, 2010 at 12:50:20AM -0700, Joel Becker wrote: > On Fri, Jun 11, 2010 at 09:19:45AM +0200, Christoph Hellwig wrote: > > On Fri, Jun 11, 2010 at 03:16:13PM +0800, Tao Ma wrote: > > > oh, that would be much work for ocfs2 to do from my perspective. = So I=20 > > > would really want to leave it as-is and I have add it to my to-do= list. > >=20 > > Oh right, you start a new transaction there. Sorry, ignore my requ= est > > and keep it as it is for now. I don't think doing truncatate in se= parate > > transactions actually is correct, though but that's no change with = this > > patch. >=20 > Christoph, > You're missing the part where actual truncate (reduce i_size) > sets i_size in ocfs2_truncate_file(). So this later code doesn't get > triggered for the truncate case. It exists for the extend case, wher= e > we extend the allocation in multiple clean transactions, then finally > set i_size in a final transaction. Actually, ocfs2_extend_file() appears to handle it too. I don't think it used to - there were places that had issues with commit_write()'s update of i_size, etc. But that's ancient history. I wonder if Mark knows. joel --=20 Dort wo man B=FCcher verbrennt, verbrennt man am Ende auch Mensch. (Wherever they burn books, they will also end up burning people.) - Heinrich Heine Joel Becker Principal Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127