From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 6/6] vmscan: Do not writeback pages in direct reclaim Date: Fri, 11 Jun 2010 12:25:23 -0400 Message-ID: <20100611162523.GA24707@infradead.org> References: <1275987745-21708-1-git-send-email-mel@csn.ul.ie> <1275987745-21708-7-git-send-email-mel@csn.ul.ie> <20100610231706.1d7528f2.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Mel Gorman , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , Chris Mason , Nick Piggin , Rik van Riel To: Andrew Morton Return-path: Content-Disposition: inline In-Reply-To: <20100610231706.1d7528f2.akpm@linux-foundation.org> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Jun 10, 2010 at 11:17:06PM -0700, Andrew Morton wrote: > As it stands, it would be wildly incautious to make a change like > this without first working out why we're pulling so many dirty pages > off the LRU tail, and fixing that. Note that unlike the writepage vs writepages from kswapd which can be fixed by the right tuning this is a black or white issue. Writeback from direct reclaim will kill your stack if the caller happens to be the wrong one, and just making it happen less often is not a fix - it must not happen at all. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org