From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 3/5] fsfreeze: freeze_super and thaw_bdev don't play well together Date: Mon, 14 Jun 2010 11:22:19 -0400 Message-ID: <20100614152219.GC32354@infradead.org> References: <1276154395-24766-1-git-send-email-david@fromorbit.com> <1276154395-24766-4-git-send-email-david@fromorbit.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, viro@ZenIV.linux.org.uk, josef@redhat.com, jeffmerkey@gmail.com To: Dave Chinner Return-path: Content-Disposition: inline In-Reply-To: <1276154395-24766-4-git-send-email-david@fromorbit.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org This breaks the "feature" that we can freeze a block device that doesn't have a filesystem mounted yet. For filesystems using get_sb_bdev that prevents a new filesystem to be mounted on them. I'm not sure it's a particularly useful feature, but it's been there since day 1 of the freeze support. The easiest way to not break it would be to keep the per-sb freeze count only for that case and only check it during mount.