From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 1/6] writeback: fix writeback completion notifications
Date: Tue, 15 Jun 2010 19:30:23 +0200
Message-ID: <20100615173023.GA6893@lst.de>
References: <20100608161424.GA11735@lst.de> <20100608161434.GB11735@lst.de> <20100615172515.GF3347@quack.suse.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Christoph Hellwig <hch@lst.de>, axboe@kernel.dk,
	linux-fsdevel@vger.kernel.org
To: Jan Kara <jack@suse.cz>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from verein.lst.de ([213.95.11.210]:37650 "EHLO verein.lst.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754298Ab0FORa2 (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 15 Jun 2010 13:30:28 -0400
Content-Disposition: inline
In-Reply-To: <20100615172515.GF3347@quack.suse.cz>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Jun 15, 2010 at 07:25:15PM +0200, Jan Kara wrote:
> > Also rename bdi_wait_on_work_clear to bdi_wait_on_work_done and inline
>   What I find slightly misleading on bdi_wait_on_work_done is that work
> isn't always "done" when this returns. For WB_SYNC_NONE writeback this
> function returns as soon as writeback thread starts the work... But I don't
> have a better name.

Well, the "work" actually is done.  For WB_SYNC_NONE that is just
kicking off the writeback, not waiting for it.