From: Arnd Bergmann <arnd@arndb.de>
To: Valerie Aurora <vaurora@redhat.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
Miklos Szeredi <miklos@szeredi.hu>, Jan Blunck <jblunck@suse.de>,
Jamie Lokier <jamie@shareable.org>,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] d_ino considered harmful
Date: Wed, 16 Jun 2010 21:10:42 +0200 [thread overview]
Message-ID: <201006162110.43322.arnd@arndb.de> (raw)
In-Reply-To: <20100616185913.GA15566@shell>
On Wednesday 16 June 2010 20:59:13 Valerie Aurora wrote:
> @@ -91,7 +91,9 @@ static int fillonedir(void * __buf, const char * name, int namlen, loff_t offset
>
> if (buf->result)
> return -EINVAL;
> - d_ino = ino;
> + /* Use of d_ino without st_dev is always buggy. */
> + d_ino = 0;
> +
> if (sizeof(d_ino) < sizeof(ino) && d_ino != ino) {
> buf->result = -EOVERFLOW;
> return -EOVERFLOW;
Isn't this just the path taken by sys_oldreaddir?
Glibc (at least on my box) translates all user calls to readdir into
sys_getdents or sys_getdents64, so I think you'd also need to change
filldir() and filldir64() for your testing.
Arnd
next prev parent reply other threads:[~2010-06-16 19:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-16 18:59 [PATCH] d_ino considered harmful Valerie Aurora
2010-06-16 19:10 ` Arnd Bergmann [this message]
2010-06-16 19:58 ` Valerie Aurora
2010-06-16 19:15 ` Jeff Layton
2010-06-16 19:58 ` Valerie Aurora
2010-06-16 19:54 ` [PATCH v2] " Valerie Aurora
2010-06-16 20:44 ` David Dillow
2010-06-17 18:04 ` J. R. Okajima
2010-06-17 18:17 ` David Dillow
2010-06-17 18:58 ` Valerie Aurora
2010-06-18 1:41 ` Andreas Dilger
2010-06-18 2:57 ` J. R. Okajima
2010-06-17 17:54 ` Jamie Lokier
2010-06-17 19:10 ` Valerie Aurora
2010-06-17 23:39 ` Andreas Dilger
2010-06-18 19:41 ` Valerie Aurora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006162110.43322.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=dwmw2@infradead.org \
--cc=hch@infradead.org \
--cc=jamie@shareable.org \
--cc=jblunck@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=vaurora@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).