From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mel Gorman Subject: Re: [PATCH 09/12] vmscan: Setup pagevec as late as possible in shrink_page_list() Date: Thu, 17 Jun 2010 11:46:23 +0100 Message-ID: <20100617104623.GB25567@csn.ul.ie> References: <1276514273-27693-1-git-send-email-mel@csn.ul.ie> <1276514273-27693-10-git-send-email-mel@csn.ul.ie> <20100616164801.9d3c0d99.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , Chris Mason , Nick Piggin , Rik van Riel , Johannes Weiner , Christoph Hellwig , KAMEZAWA Hiroyuki To: Andrew Morton Return-path: Content-Disposition: inline In-Reply-To: <20100616164801.9d3c0d99.akpm@linux-foundation.org> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Jun 16, 2010 at 04:48:01PM -0700, Andrew Morton wrote: > On Mon, 14 Jun 2010 12:17:50 +0100 > Mel Gorman wrote: > > > shrink_page_list() sets up a pagevec to release pages as according as they > > are free. It uses significant amounts of stack on the pagevec. This > > patch adds pages to be freed via pagevec to a linked list which is then > > freed en-masse at the end. This avoids using stack in the main path that > > potentially calls writepage(). > > > > hm, spose so. I cen't see any trivial way to eliminate the local > pagevec there. > > > + if (pagevec_count(&freed_pvec)) > > + __pagevec_free(&freed_pvec); > > ... > > - if (pagevec_count(&freed_pvec)) > > - __pagevec_free(&freed_pvec); > > That's an open-coded pagevec_free(). > Fair point, will correct. Thanks -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org