From: Jeff Layton <jlayton@samba.org>
To: "Justin P. Mattock" <justinmattock@gmail.com>
Cc: linux-cifs-client@lists.samba.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6 v2]cifs Fix warnings variables set but not used
Date: Sun, 20 Jun 2010 20:28:11 -0400 [thread overview]
Message-ID: <20100620202811.2d655c95@corrin.poochiereds.net> (raw)
In-Reply-To: <4C1E9752.8040508@gmail.com>
On Sun, 20 Jun 2010 15:33:54 -0700
"Justin P. Mattock" <justinmattock@gmail.com> wrote:
>
> >> /* since paths are not looked up by component - the parent
> >> directories are presumed to be good here */
> >> renew_parental_timestamps(direntry);
> >> diff --git a/fs/cifs/file.c b/fs/cifs/file.c
> >> index 75541af..73e540b 100644
> >> --- a/fs/cifs/file.c
> >> +++ b/fs/cifs/file.c
> >> @@ -1312,7 +1312,7 @@ static int cifs_partialpagewrite(struct page *page, unsigned from, unsigned to)
> >> int rc = -EFAULT;
> >> int bytes_written = 0;
> >> struct cifs_sb_info *cifs_sb;
> >> - struct cifsTconInfo *pTcon;
> >> + struct cifsTconInfo *pTcon __attribute__((unused));
> >
> > This variable can just be removed (along with the spot where it gets
> > set later).
> >
> >> struct inode *inode;
> >> struct cifsFileInfo *open_file;
> >>
> >
> >
>
> one thing I want to make sure of before sending this out, is with file.c
> if I remove *pTcon another warning shows up:
>
> CC [M] fs/cifs/file.o
> fs/cifs/file.c: In function 'cifs_partialpagewrite':
> fs/cifs/file.c:1314:23: warning: variable 'cifs_sb' set but not used
>
> with the original patch I had removed this as well, should I do this or
> is this not a good idea?
If it's not used, remove it...
--
Jeff Layton <jlayton@samba.org>
next prev parent reply other threads:[~2010-06-21 0:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-19 20:47 [PATCH 3/6 v2]cifs Fix warnings variables set but not used Justin P. Mattock
2010-06-20 21:17 ` Jeff Layton
2010-06-20 22:09 ` Justin P. Mattock
2010-06-20 22:33 ` Justin P. Mattock
2010-06-21 0:28 ` Jeff Layton [this message]
2010-06-21 1:03 ` Justin P. Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100620202811.2d655c95@corrin.poochiereds.net \
--to=jlayton@samba.org \
--cc=justinmattock@gmail.com \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).