From: Dave Chinner <david@fromorbit.com>
To: Michael Rubin <mrubin@google.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, jack@suse.cz, akpm@linux-foundation.org,
hch@lst.de, axboe@kernel.dk
Subject: Re: [PATCH 0/3] writeback visibility
Date: Mon, 21 Jun 2010 09:10:17 +1000 [thread overview]
Message-ID: <20100620231017.GI6590@dastard> (raw)
In-Reply-To: <1276907415-504-1-git-send-email-mrubin@google.com>
On Fri, Jun 18, 2010 at 05:30:12PM -0700, Michael Rubin wrote:
> Debugging writeback issues and tuning an application's writeback activity is
> easier when the activity is visible. With large clusters, classifying
> and root causing writeback problems has been a big headache. This patch
> series contains a series of patches that our team has been using to start
> getting a handle on writeback behaviour. These changes should be helpful
> for single system maintainers also. It's still a big headache.
>
> Once these changes are reviewed I will make sure the Documentation files
> are updated, but I expect some back and forth first.
>
> Michael Rubin (3):
> writeback: Creating /sys/kernel/mm/writeback/writeback
> writeback: per bdi monitoring
> writeback: tracking subsystems causing writeback
I'm not sure we want to export statistics that represent internal
implementation details into a fixed userspace API. Who, other than
developers, are going to understand and be able to make use of this
information?
FWIW, I've got to resend the writeback tracing patches to Jens that I
have that give better visibility into the writeback behaviour.
Perhaps those tracing events are a better basis for tracking down
writeback problems - the bugs I found with the tracing could not
have been found with these statistics...
That's really why I'm asking - if the stats are just there to help
development and debugging, then I think that improving the writeback
tracing is a better approach to improving visibility of writeback
behaviour...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-06-20 23:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-19 0:30 [PATCH 0/3] writeback visibility Michael Rubin
2010-06-19 0:30 ` [PATCH 1/3] writeback: Creating /sys/kernel/mm/writeback/writeback Michael Rubin
2010-06-19 10:44 ` Christoph Hellwig
2010-06-19 17:44 ` Michael Rubin
2010-06-19 0:30 ` [PATCH 2/3] writeback: per bdi monitoring Michael Rubin
2010-06-19 0:30 ` [PATCH 3/3] writeback: tracking subsystems causing writeback Michael Rubin
2010-06-19 8:17 ` Andi Kleen
2010-06-19 17:49 ` Michael Rubin
2010-06-19 20:23 ` Andi Kleen
2010-06-20 23:10 ` Dave Chinner [this message]
2010-06-21 17:09 ` [PATCH 0/3] writeback visibility Michael Rubin
2010-06-24 0:02 ` Dave Chinner
2010-06-25 7:15 ` Michael Rubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100620231017.GI6590@dastard \
--to=david@fromorbit.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mrubin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).