From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: axboe@kernel.dk, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/3] writeback: Add tracing to balance_dirty_pages
Date: Mon, 21 Jun 2010 04:12:30 -0400 [thread overview]
Message-ID: <20100621081230.GB19290@infradead.org> (raw)
In-Reply-To: <1277083526-21002-3-git-send-email-david@fromorbit.com>
> +/* pass flags explicitly */
which flags?
> + TP_fast_assign(
> + char *__name = "(none)";
> +
> + __entry->wbc = (unsigned long)wbc & 0xffff;
The wbc generally is allocated on stack, does it reall make sense to
keep this?
> + if (wbc->bdi)
> + strncpy(__entry->name, dev_name(wbc->bdi->dev), 16);
> + else
> + strncpy(__entry->name, __name, 16);
> + __entry->sb = !!wbc->sb;
The bdi and sb fields are now gone from the writeback_control. But
I think passing the bdi explicitly for the device name makes sense
here.
next prev parent reply other threads:[~2010-06-21 8:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-21 1:25 [PATCH 0/3] writeback: tracing support Dave Chinner
2010-06-21 1:25 ` [PATCH 1/3] writeback: initial " Dave Chinner
2010-06-21 8:09 ` Christoph Hellwig
2010-06-21 1:25 ` [PATCH 2/3] writeback: Add tracing to balance_dirty_pages Dave Chinner
2010-06-21 8:12 ` Christoph Hellwig [this message]
2010-06-21 1:25 ` [PATCH 3/3] writeback: Add tracing to write_cache_pages Dave Chinner
2010-06-24 12:12 ` [PATCH 0/3] writeback: tracing support Jens Axboe
2010-06-24 22:16 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2010-07-06 23:41 [PATCH 0/3] writeback: Tracing support V2 Dave Chinner
2010-07-06 23:41 ` [PATCH 2/3] writeback: Add tracing to balance_dirty_pages Dave Chinner
2010-07-07 2:20 ` Christoph Hellwig
2010-07-07 3:11 ` Dave Chinner
2010-07-07 3:24 [PATCH 0/3] writeback: Tracing support V3 Dave Chinner
2010-07-07 3:24 ` [PATCH 2/3] writeback: Add tracing to balance_dirty_pages Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100621081230.GB19290@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).