From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Subject: Re: [PATCH 1/2] radix-tree: Implement function radix_tree_range_tag_if_tagged Date: Mon, 21 Jun 2010 22:09:34 +1000 Message-ID: <20100621120934.GB31679@laptop> References: <1276706031-29421-1-git-send-email-jack@suse.cz> <1276706031-29421-2-git-send-email-jack@suse.cz> <20100618151824.397a8a35.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org To: Andrew Morton Return-path: Received: from cantor.suse.de ([195.135.220.2]:43389 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752040Ab0FUMJi (ORCPT ); Mon, 21 Jun 2010 08:09:38 -0400 Content-Disposition: inline In-Reply-To: <20100618151824.397a8a35.akpm@linux-foundation.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Jun 18, 2010 at 03:18:24PM -0700, Andrew Morton wrote: > On Wed, 16 Jun 2010 18:33:50 +0200 > Jan Kara wrote: > > > Implement function for setting one tag if another tag is set > > for each item in given range. > > > > These two patches look OK to me. > > fwiw I have a userspace test harness for radix-tree.c: > http://userweb.kernel.org/~akpm/stuff/rtth.tar.gz. Nick used it for a > while and updated it somewhat, but it's probably rather bitrotted and > surely needs to be taught how to test the post-2006 additions. > Main thing I did was add RCU support (pretty dumb RCU but it found a couple of bugs), and add some more tests. I'll try to find it...