From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wu Fengguang <fengguang.wu@intel.com>
Subject: Re: [PATCH RFC] mm: Implement balance_dirty_pages() through
 waiting for flusher thread
Date: Tue, 22 Jun 2010 12:07:27 +0800
Message-ID: <20100622040727.GA14340@localhost>
References: <1276797878-28893-1-git-send-email-jack@suse.cz>
 <1276856497.27822.1699.camel@twins>
 <20100621134238.GE3828@quack.suse.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Peter Zijlstra <peterz@infradead.org>,
	linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
	hch@infradead.org, akpm@linux-foundation.org
To: Jan Kara <jack@suse.cz>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mga01.intel.com ([192.55.52.88]:49217 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751073Ab0FVEHc (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 22 Jun 2010 00:07:32 -0400
Content-Disposition: inline
In-Reply-To: <20100621134238.GE3828@quack.suse.cz>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Mon, Jun 21, 2010 at 03:42:39PM +0200, Jan Kara wrote:
> On Fri 18-06-10 12:21:37, Peter Zijlstra wrote:
> > On Thu, 2010-06-17 at 20:04 +0200, Jan Kara wrote:
> > > +               if (bdi_stat(bdi, BDI_WRITTEN) >= bdi->wb_written_head)
> > > +                       bdi_wakeup_writers(bdi); 
> > 
> > For the paranoid amongst us you could make wb_written_head s64 and write
> > the above as:
> > 
> >   if (bdi_stat(bdi, BDI_WRITTEN) - bdi->wb_written_head > 0)
> > 
> > Which, if you assume both are monotonic and wb_written_head is always
> > within 2^63 of the actual bdi_stat() value, should give the same end
> > result and deal with wrap-around.
> > 
> > For when we manage to create a device that can write 2^64 pages in our
> > uptime :-)
>   OK, the fix is simple enough so I've changed it, although I'm not
> paranoic enough ;) (I actually did the math before writing that test).

a bit more change :)

type:

-       u64 wb_written_head
+       s64 wb_written_head

resetting:

-                       bdi->wb_written_head = ~(u64)0;
+                       bdi->wb_written_head = 0;

setting:

                bdi->wb_written_head = bdi_stat(bdi, BDI_WRITTEN) + wc->written;
+               bdi->wb_written_head |= 1;

testing:

        if (bdi->wb_written_head &&
            bdi_stat(bdi, BDI_WRITTEN) - bdi->wb_written_head > 0)

This avoids calling into bdi_wakeup_writers() pointlessly when no one
is being throttled (which is the normal case).

Thanks,
Fengguang