From: Christoph Hellwig <hch@infradead.org>
To: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: chris.mason@oracle.com, viro@zeniv.linux.org.uk,
akpm@linux-foundation.org, adilger@Sun.COM, tytso@mit.edu,
mfasheh@suse.com, joel.becker@oracle.com, matthew@wil.cx,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
ocfs2-devel@oss.oracle.com, linux-mm@kvack.org,
ngupta@vflare.org, jeremy@goop.org, JBeulich@novell.com,
kurt.hackel@oracle.com, npiggin@suse.de,
dave.mccracken@oracle.com, riel@redhat.com, avi@redhat.com,
konrad.wilk@oracle.com
Subject: Re: [PATCH V3 3/8] Cleancache: core ops functions and configuration
Date: Tue, 22 Jun 2010 10:43:20 -0400 [thread overview]
Message-ID: <20100622144320.GA13324@infradead.org> (raw)
In-Reply-To: <20100621231939.GA19505@ca-server1.us.oracle.com>
On Mon, Jun 21, 2010 at 04:19:39PM -0700, Dan Magenheimer wrote:
> [PATCH V3 3/8] Cleancache: core ops functions and configuration
>
> Cleancache core ops functions and configuration
NACK for code that just adds random hooks all over VFS and even
individual FS code, does an EXPORT_SYMBOL but doesn't actually introduce
any users.
And even if it had users these would have to be damn good ones given how
invasive it is. So what exactly is this going to help us? Given your
affiliation probably something Xen related, so some real use case would
be interesting as well instead of just making Xen suck slightly less.
next parent reply other threads:[~2010-06-22 14:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100621231939.GA19505@ca-server1.us.oracle.com>
2010-06-22 14:43 ` Christoph Hellwig [this message]
2010-06-22 15:13 ` [PATCH V3 3/8] Cleancache: core ops functions and configuration Nitin Gupta
2010-06-22 16:20 ` Dan Magenheimer
2010-06-22 16:26 ` Dave Hansen
2010-07-06 20:51 ` Konrad Rzeszutek Wilk
2010-07-07 1:02 ` Nitin Gupta
2010-07-07 13:27 ` Konrad Rzeszutek Wilk
2010-06-21 23:19 Dan Magenheimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100622144320.GA13324@infradead.org \
--to=hch@infradead.org \
--cc=JBeulich@novell.com \
--cc=adilger@Sun.COM \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=chris.mason@oracle.com \
--cc=dan.magenheimer@oracle.com \
--cc=dave.mccracken@oracle.com \
--cc=jeremy@goop.org \
--cc=joel.becker@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=kurt.hackel@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew@wil.cx \
--cc=mfasheh@suse.com \
--cc=ngupta@vflare.org \
--cc=npiggin@suse.de \
--cc=ocfs2-devel@oss.oracle.com \
--cc=riel@redhat.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).