From: Christoph Hellwig <hch@infradead.org>
To: Andi Kleen <ak@linux.intel.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Ian Munsie <imunsie@au1.ibm.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Jason Baron <jbaron@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <michael@ellerman.id.au>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Jeff Moyer <jmoyer@redhat.com>,
David Howells <dhowells@redhat.com>,
Oleg Nesterov <oleg@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@suse.de>,
Dinakar Guniguntala <dino@in.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
Eric Biederman <ebiederm@xmission.com>,
Simon Kagstrom <simon.kagstrom@netinsight.net>,
WANG Cong <amwang@redhat.
Subject: Re: [PATCH 31/40] trace syscalls: Convert various generic compat syscalls
Date: Wed, 23 Jun 2010 08:41:07 -0400 [thread overview]
Message-ID: <20100623124106.GA13200@infradead.org> (raw)
In-Reply-To: <4C21FF9A.2040207@linux.intel.com>
On Wed, Jun 23, 2010 at 02:35:38PM +0200, Andi Kleen wrote:
> >I haven't heard any complains about existing syscalls wrappers.
>
> At least for me they always interrupt my grepping.
>
> >
> >What kind of annotations could solve that?
>
> If you put the annotation in a separate macro and leave the original
> prototype alone. Then C parsers could still parse it.
I personally hate the way SYSCALL_DEFINE works with passion, mostly
for the grep reason, but also because it looks horribly ugly.
But there is no reason not to be consistent here. We already use
the wrappers for all native system calls, so leaving the compat
calls out doesn't make any sense. And I'd cheer for anyone who
comes up with a better scheme for the native and compat wrappers.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-06-23 12:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1277287401-28571-1-git-send-email-imunsie@au1.ibm.com>
2010-06-23 10:02 ` [PATCH 15/40] compat: convert fs compat to use COMPAT_SYSCALL_DEFINE#N() macros Ian Munsie
2010-06-23 10:03 ` [PATCH 31/40] trace syscalls: Convert various generic compat syscalls Ian Munsie
2010-06-23 10:19 ` Andi Kleen
2010-06-23 10:29 ` Frederic Weisbecker
2010-06-23 10:37 ` Andi Kleen
2010-06-23 11:38 ` Frederic Weisbecker
2010-06-23 12:35 ` Andi Kleen
2010-06-23 12:41 ` Christoph Hellwig [this message]
2010-06-23 15:51 ` H. Peter Anvin
2010-06-24 12:05 ` Michal Marek
2010-06-24 12:05 ` Michal Marek
2010-06-24 12:05 ` Michal Marek
2010-06-24 12:05 ` Michal Marek
2010-06-23 10:30 ` KOSAKI Motohiro
2010-06-23 10:03 ` [PATCH 32/40] trace syscalls: Record metadata for syscalls with their own wrappers Ian Munsie
2010-06-23 10:03 ` [PATCH 34/40] trace syscalls: Convert generic syscalls without long return type Ian Munsie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100623124106.GA13200@infradead.org \
--to=hch@infradead.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=amwang@redhat. \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dino@in.ibm.com \
--cc=ebiederm@xmission.com \
--cc=fweisbec@gmail.com \
--cc=gregkh@suse.de \
--cc=imunsie@au1.ibm.com \
--cc=jbaron@redhat.com \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=simon.kagstrom@netinsight.net \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).