From: Andi Kleen <andi@firstfloor.org>
To: Kees Cook <kees.cook@canonical.com>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] security: Yama LSM
Date: Wed, 23 Jun 2010 17:34:08 +0200 [thread overview]
Message-ID: <20100623153408.GA15787@basil.fritz.box> (raw)
In-Reply-To: <20100623145437.GJ5876@outflux.net>
On Wed, Jun 23, 2010 at 07:54:37AM -0700, Kees Cook wrote:
> Oh, er, I actually added these configs because Eric Paris recommended them
> as handy for distributions. I'm fine with dropping them, but will I be
Distributions should use init scripts for that imho.
> asked to add them back later? And what about the case of CONFIG_SYSCTL
> being unset?
"depends on SYSCTL"
>
> > However the help texts are useful, these should be in the sysctl
> > documentatin in Documentation instead.
>
> I documented the sysctls in Documentation/Yama.txt (where SELinux.txt and
> Smack.txt live) should I create an additional file in Documentation/sysctl/
> with that information (moved from Yama.txt) or move Yama.txt there?
Ok missed that. what you prefer.
> I actually think this is a flaw in get_task_comm. (Though actually it's
> the fault of terminals if they process dangerous escape sequences. Worst
> case tends to just be confusing output, but that's not important --
> nothing should spew non-printables regardless.) Would a patch to
> get_task_comm be accepted to replace non-printables with "?" or something
> when filling the buffer?
Probably makes sense, although you might annoy someone who wants Kanji
process names in UTF-8 or similar.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-06-23 15:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 6:52 [PATCH v2] security: Yama LSM Kees Cook
2010-06-23 11:43 ` Andi Kleen
2010-06-23 14:54 ` Kees Cook
2010-06-23 15:34 ` Andi Kleen [this message]
2010-06-23 15:59 ` Alan Cox
2010-06-23 19:10 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100623153408.GA15787@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=kees.cook@canonical.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).