From: Christoph Hellwig <hch@lst.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Christoph Hellwig <hch@lst.de>,
viro@zeniv.linux.org.uk, drepper@redhat.com,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] pass a struct path to vfs_statfs
Date: Sat, 26 Jun 2010 12:08:21 +0200 [thread overview]
Message-ID: <20100626100821.GA27613@lst.de> (raw)
In-Reply-To: <20100626200540.1f9c9cb5.sfr@canb.auug.org.au>
On Sat, Jun 26, 2010 at 08:05:40PM +1000, Stephen Rothwell wrote:
> > -do_osf_statfs(struct dentry * dentry, struct osf_statfs __user *buffer,
> > +do_osf_statfs(struct path *path, struct osf_statfs __user *buffer,
> > unsigned long bufsiz)
> > {
> > - struct kstatfs linux_stat;
> > - int error = vfs_statfs(dentry, &linux_stat);
> > - if (!error)
> > - error = linux_to_osf_statfs(&linux_stat, buffer, bufsiz);
> > return error;
> > }
>
> That can't be right ...
Yeah, this should have been removed entirely, or I should have just
dropped the unrelated cleanup from this patch. I'll fix it up for the
next version.
next prev parent reply other threads:[~2010-06-26 10:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-26 9:34 [PATCH 1/2] pass a struct path to vfs_statfs Christoph Hellwig
2010-06-26 10:05 ` Stephen Rothwell
2010-06-26 10:08 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-07-07 16:53 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100626100821.GA27613@lst.de \
--to=hch@lst.de \
--cc=drepper@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).