From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/2] pass a struct path to vfs_statfs Date: Sat, 26 Jun 2010 12:08:21 +0200 Message-ID: <20100626100821.GA27613@lst.de> References: <20100626093457.GA26371@lst.de> <20100626200540.1f9c9cb5.sfr@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , viro@zeniv.linux.org.uk, drepper@redhat.com, linux-fsdevel@vger.kernel.org To: Stephen Rothwell Return-path: Received: from verein.lst.de ([213.95.11.210]:38279 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752389Ab0FZKIl (ORCPT ); Sat, 26 Jun 2010 06:08:41 -0400 Content-Disposition: inline In-Reply-To: <20100626200540.1f9c9cb5.sfr@canb.auug.org.au> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, Jun 26, 2010 at 08:05:40PM +1000, Stephen Rothwell wrote: > > -do_osf_statfs(struct dentry * dentry, struct osf_statfs __user *buffer, > > +do_osf_statfs(struct path *path, struct osf_statfs __user *buffer, > > unsigned long bufsiz) > > { > > - struct kstatfs linux_stat; > > - int error = vfs_statfs(dentry, &linux_stat); > > - if (!error) > > - error = linux_to_osf_statfs(&linux_stat, buffer, bufsiz); > > return error; > > } > > That can't be right ... Yeah, this should have been removed entirely, or I should have just dropped the unrelated cleanup from this patch. I'll fix it up for the next version.