linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Neil Brown <neilb@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
	viro@zeniv.linux.org.uk, drepper@redhat.com,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] add f_flags to struct statfs(64)
Date: Sat, 26 Jun 2010 15:12:08 +0200	[thread overview]
Message-ID: <20100626131208.GB1838@lst.de> (raw)
In-Reply-To: <20100626225547.52e76eb2@notabene.brown>

On Sat, Jun 26, 2010 at 10:55:47PM +1000, Neil Brown wrote:
>  while we are adding flags to statfs, I wonder if it might be possible to do
>  something to make f_fsid more useful - particularly for nfs-utils.

f_fsid really isn't suitable for that.  Even filesystems that had UUIDs
since the dawn of days don't always store it there, e.g. XFS.  I wish
people had left it with that, but the recent rush to stupidly overload
it with an uuid light and using it in nfs-tools didn't help.

Having an API to expose a UUID to userspace would be useful, but f_fsid
isn't it.  If we'll have to add real statvfs syscalls we can add an
f_uuid field, but I'd rather not use up the reamining space in the
statfs structure for that.


  reply	other threads:[~2010-06-26 13:12 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-26  9:35 [PATCH 2/2] add f_flags to struct statfs(64) Christoph Hellwig
2010-06-26  9:56 ` Nick Piggin
2010-06-26 13:09   ` Christoph Hellwig
2010-06-26 13:16     ` Nick Piggin
2010-06-26 12:55 ` Neil Brown
2010-06-26 13:12   ` Christoph Hellwig [this message]
2010-06-27  7:55 ` Tao Ma
2010-06-27  9:20   ` Christoph Hellwig
2010-06-28 18:43 ` Andreas Dilger
2010-06-28 19:52   ` Ulrich Drepper
2010-06-28 20:07     ` Andreas Dilger
2010-06-29  8:57     ` Nick Piggin
2010-06-29  9:25       ` Christoph Hellwig
2010-06-29  9:59       ` Ulrich Drepper
2010-06-29 11:05         ` Nick Piggin
2010-06-29 12:57         ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2010-07-07 16:53 Christoph Hellwig
2010-07-07 17:11 ` Ulrich Drepper
2010-07-07 17:31   ` Linus Torvalds
2010-07-07 17:33     ` Christoph Hellwig
2010-07-07 17:55       ` Miklos Szeredi
2010-07-07 18:06         ` Linus Torvalds
2010-07-07 18:50           ` Nick Piggin
2010-07-07 19:30             ` Linus Torvalds
2010-07-18  6:41               ` Christoph Hellwig
2010-07-18 17:03                 ` Linus Torvalds
2010-07-07 18:16       ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100626131208.GB1838@lst.de \
    --to=hch@lst.de \
    --cc=drepper@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).