From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Subject: Re: [PATCH 2/2] add f_flags to struct statfs(64) Date: Sat, 26 Jun 2010 23:16:50 +1000 Message-ID: <20100626131650.GK29809@laptop> References: <20100626093507.GB26371@lst.de> <20100626095652.GI29809@laptop> <20100626130928.GA1838@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: viro@zeniv.linux.org.uk, drepper@redhat.com, linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from cantor.suse.de ([195.135.220.2]:58939 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755863Ab0FZNQz (ORCPT ); Sat, 26 Jun 2010 09:16:55 -0400 Content-Disposition: inline In-Reply-To: <20100626130928.GA1838@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, Jun 26, 2010 at 03:09:28PM +0200, Christoph Hellwig wrote: > On Sat, Jun 26, 2010 at 07:56:53PM +1000, Nick Piggin wrote: > > Is f_favail important enough to add as well? > > As Uli if he needs it. Adding real support for it won't be quite > as easy as adding f_flags, as the individual filesystems would need > to support it. > > And those not derived from FFS generally don't > have any different accounting of inodes allocates vs inodes allocated to > non-root user. In fact faking up any kind of free inodes values is > already difficult enough for modern filesystems. Yeah, quite likely it is not worth using up another field for this, and instead the statvfs Linux man page should be updated instead.