From: Kees Cook <kees.cook@canonical.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
Oleg Nesterov <oleg@redhat.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Neil Horman <nhorman@tuxdriver.com>,
Roland McGrath <roland@redhat.com>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] sanitize task->comm to avoid leaking escape codes
Date: Mon, 28 Jun 2010 14:03:42 -0700 [thread overview]
Message-ID: <20100628210342.GW4175@outflux.net> (raw)
In-Reply-To: <20100628130028.73757a46.akpm@linux-foundation.org>
Hi,
On Mon, Jun 28, 2010 at 01:00:28PM -0700, Andrew Morton wrote:
> Surely it would be better to fix the tools which display this info
> rather than making the kernel tell fibs.
The strncpy in get_task_comm() is totally wrong -- it's testing the length
of task->comm. Why should get_task_comm not take a destination buffer
length argument? At least consider v2 of the patch -- it just fixes the
get_task_comm definition and callers.
But, if not, then patches to the kernel that include
printk(..., get_task_comm(...) ...) shouldn't be considered flawed[1].
-Kees
[1] http://lkml.org/lkml/2010/6/23/132
--
Kees Cook
Ubuntu Security Team
next prev parent reply other threads:[~2010-06-28 21:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 18:11 [PATCH] sanitize task->comm to avoid leaking escape codes Kees Cook
2010-06-23 19:41 ` Oleg Nesterov
2010-06-23 20:23 ` Alexey Dobriyan
2010-06-23 21:28 ` Kees Cook
2010-06-28 20:00 ` Andrew Morton
2010-06-28 21:03 ` Kees Cook [this message]
2010-06-29 8:45 ` Alexey Dobriyan
2010-06-29 15:09 ` Kees Cook
2010-06-29 18:59 ` Andrew Morton
2010-06-29 19:13 ` Kees Cook
2010-06-29 4:58 ` Artem Bityutskiy
2010-06-29 13:31 ` Oleg Nesterov
2010-06-29 16:23 ` Paul E. McKenney
2010-06-29 17:18 ` Oleg Nesterov
2010-06-29 17:33 ` Paul E. McKenney
2010-06-29 22:32 ` john stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100628210342.GW4175@outflux.net \
--to=kees.cook@canonical.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nhorman@tuxdriver.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=roland@redhat.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).