From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Subject: Re: [PATCH 2/2] add f_flags to struct statfs(64) Date: Tue, 29 Jun 2010 18:57:59 +1000 Message-ID: <20100629085759.GN28364@laptop> References: <20100626093507.GB26371@lst.de> <60FB0305-A632-4A63-9BD8-DA07CC69B7D7@dilger.ca> <4C28FD98.1010300@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andreas Dilger , Christoph Hellwig , viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org To: Ulrich Drepper Return-path: Received: from cantor2.suse.de ([195.135.220.15]:50921 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754398Ab0F2I6D (ORCPT ); Tue, 29 Jun 2010 04:58:03 -0400 Content-Disposition: inline In-Reply-To: <4C28FD98.1010300@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Jun 28, 2010 at 12:52:56PM -0700, Ulrich Drepper wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 06/28/2010 11:43 AM, Andreas Dilger wrote: > > I would advocate at least an 8-bit magic value, if there is a concern > > about this field not always being 0-filled on older kernels, or not > > using any ST_VALID flag at all, if it was always zero-filled in the > > past. ST_VALID is required to differentiate between no flags, and flags field unsupported of course. > Did anyone go back and check which kernel versions didn't clear the > spare fields (if any)? At least from 2.4.0 does memset it. 2.2.26 does not. Can you live with that?