From: Christoph Hellwig <hch@lst.de>
To: Nick Piggin <npiggin@suse.de>
Cc: Ulrich Drepper <drepper@redhat.com>,
Andreas Dilger <adilger@dilger.ca>,
Christoph Hellwig <hch@lst.de>,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] add f_flags to struct statfs(64)
Date: Tue, 29 Jun 2010 11:25:58 +0200 [thread overview]
Message-ID: <20100629092558.GA27397@lst.de> (raw)
In-Reply-To: <20100629085759.GN28364@laptop>
On Tue, Jun 29, 2010 at 06:57:59PM +1000, Nick Piggin wrote:
> On Mon, Jun 28, 2010 at 12:52:56PM -0700, Ulrich Drepper wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > On 06/28/2010 11:43 AM, Andreas Dilger wrote:
> > > I would advocate at least an 8-bit magic value, if there is a concern
> > > about this field not always being 0-filled on older kernels, or not
> > > using any ST_VALID flag at all, if it was always zero-filled in the
> > > past.
>
> ST_VALID is required to differentiate between no flags, and
> flags field unsupported of course.
Yes, that was my intention for it.
>
> > spare fields (if any)?
>
> At least from 2.4.0 does memset it. 2.2.26 does not. Can you
> live with that?
The spare fields in struct statfs have been zeroed since 2.3.99pre3-8,
before that they were set to a pattern of 0xff.
next prev parent reply other threads:[~2010-06-29 9:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-26 9:35 [PATCH 2/2] add f_flags to struct statfs(64) Christoph Hellwig
2010-06-26 9:56 ` Nick Piggin
2010-06-26 13:09 ` Christoph Hellwig
2010-06-26 13:16 ` Nick Piggin
2010-06-26 12:55 ` Neil Brown
2010-06-26 13:12 ` Christoph Hellwig
2010-06-27 7:55 ` Tao Ma
2010-06-27 9:20 ` Christoph Hellwig
2010-06-28 18:43 ` Andreas Dilger
2010-06-28 19:52 ` Ulrich Drepper
2010-06-28 20:07 ` Andreas Dilger
2010-06-29 8:57 ` Nick Piggin
2010-06-29 9:25 ` Christoph Hellwig [this message]
2010-06-29 9:59 ` Ulrich Drepper
2010-06-29 11:05 ` Nick Piggin
2010-06-29 12:57 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2010-07-07 16:53 Christoph Hellwig
2010-07-07 17:11 ` Ulrich Drepper
2010-07-07 17:31 ` Linus Torvalds
2010-07-07 17:33 ` Christoph Hellwig
2010-07-07 17:55 ` Miklos Szeredi
2010-07-07 18:06 ` Linus Torvalds
2010-07-07 18:50 ` Nick Piggin
2010-07-07 19:30 ` Linus Torvalds
2010-07-18 6:41 ` Christoph Hellwig
2010-07-18 17:03 ` Linus Torvalds
2010-07-07 18:16 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100629092558.GA27397@lst.de \
--to=hch@lst.de \
--cc=adilger@dilger.ca \
--cc=drepper@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).