From: Nick Piggin <npiggin@suse.de>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Andreas Dilger <adilger@dilger.ca>,
Christoph Hellwig <hch@lst.de>,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] add f_flags to struct statfs(64)
Date: Tue, 29 Jun 2010 21:05:38 +1000 [thread overview]
Message-ID: <20100629110538.GO28364@laptop> (raw)
In-Reply-To: <4C29C3F9.7030805@redhat.com>
On Tue, Jun 29, 2010 at 02:59:21AM -0700, Ulrich Drepper wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 06/29/2010 01:57 AM, Nick Piggin wrote:
> > ST_VALID is required to differentiate between no flags, and
> > flags field unsupported of course.
>
> Not needed if a new syscall would be used.
True, but we have the spare fields.
> > At least from 2.4.0 does memset it. 2.2.26 does not. Can you
> > live with that?
>
> We still support building glibc for everything from linux 2.0 on, at
> least for x86. I really have no idea whether such old kernels are still
> in use and if yes, whether userland gets updated. I wouldn't have a
> problem with bumping the minimum required kernel version.
I guess most would assume a 2.6 kernel nowadays? With either the
new syscall or Christoph's patch, you need to keep the fallback
around too.
next prev parent reply other threads:[~2010-06-29 11:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-26 9:35 [PATCH 2/2] add f_flags to struct statfs(64) Christoph Hellwig
2010-06-26 9:56 ` Nick Piggin
2010-06-26 13:09 ` Christoph Hellwig
2010-06-26 13:16 ` Nick Piggin
2010-06-26 12:55 ` Neil Brown
2010-06-26 13:12 ` Christoph Hellwig
2010-06-27 7:55 ` Tao Ma
2010-06-27 9:20 ` Christoph Hellwig
2010-06-28 18:43 ` Andreas Dilger
2010-06-28 19:52 ` Ulrich Drepper
2010-06-28 20:07 ` Andreas Dilger
2010-06-29 8:57 ` Nick Piggin
2010-06-29 9:25 ` Christoph Hellwig
2010-06-29 9:59 ` Ulrich Drepper
2010-06-29 11:05 ` Nick Piggin [this message]
2010-06-29 12:57 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2010-07-07 16:53 Christoph Hellwig
2010-07-07 17:11 ` Ulrich Drepper
2010-07-07 17:31 ` Linus Torvalds
2010-07-07 17:33 ` Christoph Hellwig
2010-07-07 17:55 ` Miklos Szeredi
2010-07-07 18:06 ` Linus Torvalds
2010-07-07 18:50 ` Nick Piggin
2010-07-07 19:30 ` Linus Torvalds
2010-07-18 6:41 ` Christoph Hellwig
2010-07-18 17:03 ` Linus Torvalds
2010-07-07 18:16 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100629110538.GO28364@laptop \
--to=npiggin@suse.de \
--cc=adilger@dilger.ca \
--cc=drepper@redhat.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox